pvillard31 commented on code in PR #11628:
URL: https://github.com/apache/nifi/pull/11628#discussion_r3956181079
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/web/api/TestFlowResource.java:
##########
@@ -276,13 +276,13 @@ public void testGetFlowMetricsPrometheusAsJson() throws
IOException {
assertTrue(metrics.containsKey(ROOT_FIELD_NAME));
final List<Sample> registryList = metrics.get(ROOT_FIELD_NAME);
- assertEquals(13, registryList.size());
+ assertEquals(15, registryList.size());
Review Comment:
Can we assert the names and values of both new metrics instead of only
updating the sample counts? The current assertions would pass if either metric
were renamed or its boolean value were inverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
