joewitt commented on PR #11648: URL: https://github.com/apache/nifi/pull/11648#issuecomment-5591047611
Mock runner never exercises session-committed counters. testAdjustCounter always uses true / CommitTiming.NOW. Gauges have both NOW and SESSION_COMMITTED. StandardProcessSessionTest covers commit-time counters; MockProcessSession does not. A one-liner processor that calls adjustCounter(..., CommitTiming.SESSION_COMMITTED) would catch a commit/rollback bug in the mock. SharedSessionState.getGaugeValues(name) returns a live ArrayList; the attributed overload returns List.copyOf. Callers of the old method can mutate the store. Pre-existing flavor of leak, now more visible. Cheap to return List.copyOf(gaugeValues) on both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
