[
https://issues.apache.org/jira/browse/NIFI-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875450#comment-15875450
]
ASF GitHub Bot commented on NIFI-3505:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/1523
NIFI-3505: Fix nifi.sh restart
The 'exec' command added by NIFI-2689 affected restart behavior
negatively as 'exec' command will not execute subsequent commands in the
shell script.
This commit changes 'exec' is added only when 'run' is specified.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-3505
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1523.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1523
----
commit f9e78750d9cd7c393a2dfd27b0396504f530d209
Author: Koji Kawamura <[email protected]>
Date: 2017-02-21T06:41:51Z
NIFI-3505: Fix nifi.sh restart
The 'exec' command added by NIFI-2689 affected restart behavior
negatively as 'exec' command will not execute subsequent commands in the
shell script.
This commit changes 'exec' is added only when 'run' is specified.
----
> nifi.sh restart doesn't restart properly
> ----------------------------------------
>
> Key: NIFI-3505
> URL: https://issues.apache.org/jira/browse/NIFI-3505
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
> Affects Versions: 1.2.0
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
>
> When I run "nifi.sh restart" using the latest master as of Feb 20, it behaves
> differently compared to how it used to.
> * If NiFi is not running, "nifi.sh restart" used to start new nifi process,
> but currently it doesn't.
> * If NiFi is running, "nifi.sh restart" used to shutdown existing nifi
> process, and start new one. But it just shutdown existing one, and don't
> start new one.
> It's caused by recent changes to nifi.sh. NIFI-2689 added 'exec' command.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
