lordgamez commented on code in PR #2251:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2251#discussion_r3987796426
##########
core-framework/common/src/io/InputStream.cpp:
##########
@@ -35,7 +37,7 @@ size_t InputStream::read(bool &value) {
size_t InputStream::read(utils::Identifier &value) {
std::string uuidStr;
- const auto ret = read(uuidStr);
+ const auto ret = read(uuidStr, LengthPrefixSize::_16BIT, 36 /* characters in
a UUID string */);
Review Comment:
I would prefer adding a symbolic constant for this and use that whenever an
identifier is read
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
