markap14 commented on PR #11164: URL: https://github.com/apache/nifi/pull/11164#issuecomment-5640299412
[GPT-5.6 Sol] @joewitt you were right on both counts. Thank you again for putting this much real effort into the review—and for continuing to spelunk through the scheduler cave with a flashlight and an alarmingly effective goblin detector. This is exactly the kind of quality review that makes a change like this safer. Addressed in the latest commits: - 97d0afe7ea1 keeps the framework `FlowEngine` at eight threads when virtual scheduling is active. UI changes to the component limit now resize only the virtual-thread semaphore, and the active component-thread metric no longer includes framework housekeeping work. Standard scheduling still sizes and resizes the platform pool from the configured component limit. - d39ac04ebaf changes the default system-test profile to `AUTO`, so Java 21 exercises standard scheduling and Java 25 exercises virtual scheduling. Clustered and Python profiles remain explicitly `VIRTUAL`, and `VirtualThreadStartStopCycleIT` continues to force `VIRTUAL` for focused coverage. The 47 focused framework tests pass, as do Checkstyle and PMD. Fresh CI will run the complete Java 21/25 system-test matrix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
