markobean commented on PR #11582:
URL: https://github.com/apache/nifi/pull/11582#issuecomment-5674378746
> Thanks for restoring View Connections. The effect/filter path and
unauthorized/empty handling look directionally right, but this isn’t
merge-ready yet.
>
> Verified locally on this branch (`npx nx test nifi --runInBand`): 6 failed
/ 2,825 passed, all in `component-connections-dialog.component.spec.ts`. Lint
and a development build passed.
>
> Must-fix before merge:
>
> 1. The new dialog tests fail (empty mock store + assertions still
targeting `goTo()` / a partial row shape).
> 2. Remote-port cells navigate with the port id and
`ComponentType.RemoteProcessGroup`.
> 3. Source/Destination Process Group cells navigate to
`/process-groups/{groupId}/ProcessGroup/{groupId}` when the endpoint is the
group currently on the canvas.
>
> The five-column clickable table is a reasonable UX, but it should follow
the existing dialog listing-table pattern (bounded scroll, sticky header,
striped rows) used by Local Changes and Change Version, and use `<a>` for
in-cell navigation rather than `mat-button`.
@rfellows Thanks for taking the time to review and catch a few things that
needed attention.
I'm made numerous updates.
1. The tests were refactored completely. The original submission had tests
leftover from the original implementation. They are now current and all pass
with `npx nx test nifi --runInBand`.
2. Remote port components are no longer clickable in the table since they
are not rendered on the local canvas.
3. Any source/destination process group which is the current process group
is non-clickable
4. Table "buttons" were replaced with more native <span> and <a> elements.
5. Syntax for styles were updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
