markobean commented on code in PR #11582:
URL: https://github.com/apache/nifi/pull/11582#discussion_r4050600783


##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/service/canvas-context-menu.service.ts:
##########
@@ -287,25 +289,23 @@ export class CanvasContextMenu implements 
ContextMenuDefinitionProvider {
         id: 'upstream-downstream',
         menuItems: [
             {
-                condition: () => {
-                    // TODO - hasUpstream
-                    return false;
+                condition: (selection: d3.Selection<any, any, any, any>) => {
+                    return this.canvasUtils.hasUpstream(selection);
                 },

Review Comment:
   Updated to allow right-clicking on whitespace/empty canvas and still 
producing the upstream/downstream selection relative to the current process 
group.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to