[
https://issues.apache.org/jira/browse/NIFI-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876674#comment-15876674
]
ASF GitHub Bot commented on NIFI-2829:
--------------------------------------
GitHub user patricker opened a pull request:
https://github.com/apache/nifi/pull/1524
NIFI-2829 Date and Time
@paulgibeault made the original PR for this, #1073.
We lost a bit of traction, had some technical issues, and it just didn't
get merged.
Then #1468 came along and covered a portion of the work with a great
approach. (thanks @nickcarenza)
I've gone back and updated the original code to work with the new paradigm
introduced by #1468 so that it also supports `DATE` and `TIME` column types,
and not just `TIMESTAMP` ones.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/patricker/nifi NIFI-2829
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1524.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1524
----
commit 8c0108d914c0f6d2f574f725945c33dfa5cfe522
Author: patricker <[email protected]>
Date: 2017-02-21T20:22:04Z
NIFI-2829
----
> PutSQL assumes all Date and Time values are provided in Epoch
> -------------------------------------------------------------
>
> Key: NIFI-2829
> URL: https://issues.apache.org/jira/browse/NIFI-2829
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.2.0
> Reporter: Paul Gibeault
> Assignee: Peter Wicks
> Fix For: 1.2.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> This bug is the same as NIFI-2576 only extended to data types DATE and TIME.
> https://issues.apache.org/jira/browse/NIFI-2576
> When PutSQL sees a DATE or TIME data type it assumes that it's being provided
> as a Long in Epoch format.
> This doesn't make much sense since the Query Database tools that return Avro
> return DATES and TIME values as strings; and thus following the
> Avro->JSON->JSON To SQL Route leads to DATE and TIME fields as being strings.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
