lordgamez commented on code in PR #2269:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2269#discussion_r4155166679
##########
extensions/aws/controllerservices/AWSCredentialsService.cpp:
##########
@@ -28,25 +32,49 @@ void AWSCredentialsService::initialize() {
}
void AWSCredentialsService::onEnable() {
+ AWSCredentialsProviderSettings settings;
if (const auto access_key = getProperty(AccessKey.name)) {
- aws_credentials_provider_.setAccessKey(*access_key);
+ settings.access_key = *access_key;
}
if (const auto secret_key = getProperty(SecretKey.name)) {
- aws_credentials_provider_.setSecretKey(*secret_key);
+ settings.secret_key = *secret_key;
}
if (const auto credentials_file = getProperty(CredentialsFile.name)) {
- aws_credentials_provider_.setCredentialsFile(*credentials_file);
+ settings.credentials_file = *credentials_file;
+ }
+ if (const auto profile_name = getProperty(ProfileName.name)) {
+ settings.profile_name = *profile_name;
+ }
+ if (const auto sso_profile_name = getProperty(SSOProfileName.name)) {
+ settings.sso_profile_name = *sso_profile_name;
}
- if (const auto use_credentials = getProperty(UseDefaultCredentials.name) |
minifi::utils::andThen(parsing::parseBool)) {
- aws_credentials_provider_.setUseDefaultCredentials(*use_credentials);
+ if (const auto use_default_credentials =
getProperty(UseDefaultCredentials.name) |
minifi::utils::andThen(parsing::parseBool); use_default_credentials &&
*use_default_credentials) {
+ settings.credential_configuration_strategy =
CredentialConfigurationStrategyOption::DefaultCredentials;
Review Comment:
This is an improvement as having this fallback would cause confusion which
credentials are used. Setting the Use Default Credentials property should
override the credentials set in the properties and in case it cannot be
retrieved it should not fail silently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
