Copilot commented on code in PR #2271:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2271#discussion_r4164036274
##########
win_build_vs.bat:
##########
@@ -84,6 +87,9 @@ for %%x in (%*) do (
if [%%~x] EQU [/NO_PYTHON_SCRIPTING] set enable_python_scripting=OFF
if [%%~x] EQU [/LOKI] set enable_grafana_loki=ON
if [%%~x] EQU [/COUCHBASE] set enable_couchbase=ON
+ if [%%~x] EQU [/RUST] set enable_rust=ON
+ if [%%~x] EQU [/NO_PGP] set enable_pgp=OFF
+ if [%%~x] EQU [/NO_TENSOR] set enable_tensor=OFF
Review Comment:
The public Windows build options table in `Windows.md:65-100` documents this
script's switches, but it does not list `/RUST`, `/NO_PGP`, or `/NO_TENSOR`.
Add these switches there so users can discover how to enable Rust and select
its extensions.
##########
minifi_rust/CMakeLists.txt:
##########
@@ -43,6 +43,10 @@ if (NOT MINIFI_EXTENSION_PGP)
set_target_properties(cargo-build_minifi_pgp PROPERTIES EXCLUDE_FROM_ALL
TRUE)
endif()
+if (NOT MINIFI_EXTENSION_TENSOR)
+ set_target_properties(cargo-build_minifi_tensor PROPERTIES
EXCLUDE_FROM_ALL TRUE)
+endif()
Review Comment:
`EXCLUDE_FROM_ALL` only removes the Corrosion target from CMake's default
target. The `cargo_build_tests` target and `cargo_tests` test below still run
`cargo test` at the virtual-workspace root, which selects every workspace
member; therefore `/RUST /NO_TENSOR` still compiles and tests `minifi_tensor`
(and `/NO_PGP` has the same problem). Build matching Cargo exclusion arguments
and pass them to both commands so disabled extensions are actually omitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
