fgerlits commented on code in PR #2275:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2275#discussion_r4184960510
##########
minifi_rust/CMakeLists.txt:
##########
@@ -39,11 +39,15 @@ if (NOT ENABLE_TEST_PROCESSORS)
set_target_properties(cargo-build_minifi_rs_playground PROPERTIES
EXCLUDE_FROM_ALL TRUE)
endif()
-if (NOT MINIFI_EXTENSION_PGP)
+if (MINIFI_EXTENSION_PGP)
+ register_rust_extension(minifi_pgp "PGP EXTENSION" MINIFI_EXTENSION_PGP
"This enables EncryptContentPGP and DecryptContentPGP")
+else()
set_target_properties(cargo-build_minifi_pgp PROPERTIES EXCLUDE_FROM_ALL
TRUE)
endif()
-if (NOT MINIFI_EXTENSION_TENSOR)
+if (MINIFI_EXTENSION_TENSOR)
+ register_rust_extension(minifi_tensor "TENSOR EXTENSION"
MINIFI_EXTENSION_TENSOR "This enables tract based tensor processors")
Review Comment:
"tract" is too common a word:
```suggestion
register_rust_extension(minifi_tensor "TENSOR EXTENSION"
MINIFI_EXTENSION_TENSOR "This enables sonos/tract based tensor processors")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
