[
https://issues.apache.org/jira/browse/NIFI-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878509#comment-15878509
]
ASF subversion and git services commented on NIFI-2689:
-------------------------------------------------------
Commit 8d467f3d1fe9b9e96e67f2979aa5676465afedc1 in nifi's branch
refs/heads/master from [~ijokarumawak]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=8d467f3 ]
NIFI-3505: Fix nifi.sh restart
The 'exec' command added by NIFI-2689 affected restart behavior
negatively as 'exec' command will not execute subsequent commands in the
shell script.
This commit changes 'exec' is added only when 'run' is specified.
This closes #1523.
Signed-off-by: Aldrin Piri <[email protected]>
> better foreground run for nifi.sh to improve supervision
> --------------------------------------------------------
>
> Key: NIFI-2689
> URL: https://issues.apache.org/jira/browse/NIFI-2689
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
> Affects Versions: 1.0.0
> Environment: *nix
> Reporter: Hunter Morgan
> Assignee: Hunter Morgan
> Priority: Minor
> Labels: easyfix, patch
> Fix For: 1.2.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The launch script (nifi.sh) has a run argument that "supports" running in
> foreground. This could be useful with supervisors such as runit, however, the
> indirection provided by a subshell and an eval allow the instance to be
> detached from the session in certain circumstances and break trivial
> compatibility with runit.
> Adding an exec to RUN_NIFI_CMD before the sudo prefix, and removing the
> subshell invocation from the start argument else is a fix for my purposes.
> Something more considerate may be better. Additionally, if the feature should
> be desired in other similar launcher scripts, if there is an upstream source
> of that pattern I'm unaware of, it should be similarly modified.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
