bobpaulin commented on code in PR #11789:
URL: https://github.com/apache/nifi/pull/11789#discussion_r4224138738
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/components/connector/StandardConnectorRepository.java:
##########
@@ -299,6 +327,8 @@ public ConnectorSyncResult syncConnector(final
VersionedConnector versionedConne
return ConnectorSyncResult.syncedConfigUnchanged(connector,
effectiveScheduledState);
}
+ saveMigratedWorkingConfiguration(connectorId, connector,
migratedProviderConfig);
Review Comment:
Saving will update the external provide with a change the user has not yet
made. I do not think we should do that here we should instead let the
in-memory defaults take effect without changing the external provider.
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/components/connector/StandardConnectorRepository.java:
##########
@@ -291,6 +317,8 @@ public ConnectorSyncResult syncConnector(final
VersionedConnector versionedConne
connector.restoreTroubleshootingState();
}
+ saveMigratedWorkingConfiguration(connectorId, connector,
migratedProviderConfig);
Review Comment:
Saving will update the external provide with a change the user has not yet
made. I do not think we should do that here we should instead let the
in-memory defaults take effect without changing the external provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
