exceptionfactory commented on code in PR #11810:
URL: https://github.com/apache/nifi/pull/11810#discussion_r4325458209
##########
nifi-stateless/nifi-stateless-bootstrap/src/main/java/org/apache/nifi/stateless/bootstrap/AllowListClassLoader.java:
##########
@@ -128,8 +128,11 @@ private boolean isClassAllowed(final String name, final
Class<?> clazz) {
return false;
}
}
-
- private boolean isModuleAllowed(final String moduleName) {
+ // Package-private for testing
+ boolean isModuleAllowed(final String moduleName) {
Review Comment:
The method should be kept `private`, it does not need to be directly exposed
for testing.
##########
nifi-stateless/nifi-stateless-bootstrap/src/test/java/org/apache/nifi/stateless/bootstrap/TestAllowListClassLoader.java:
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.stateless.bootstrap;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.Collections;
+import java.util.Set;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+
+class TestAllowListClassLoader {
+
+ @Test
+ void testIsModuleAllowedNullReturnsFalse() {
+ final AllowListClassLoader classLoader = new AllowListClassLoader(
+ ClassLoader.getSystemClassLoader(),
+ Collections.emptySet()
+ );
+
+ // Before fix: moduleName.startsWith(...) threw NullPointerException
+ // After fix: returns false safely
Review Comment:
These types of comments should be removed, there is no need for historical
reference to failing behavior in comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
