sejal-gupta-ksolves commented on PR #11833: URL: https://github.com/apache/nifi/pull/11833#issuecomment-6362483707
Thanks for the review @exceptionfactory and @mosermw . I've pushed an update: - Name: renamed to LookupRecordAttribute. mosermw, you're right: what's new is the use of a RecordLookupService rather than a String one, so the name now says that. - Style: removed public from the property descriptors and relationships, and changed @CapabilityDescription to a text block. - Batching: removed the hard-coded batch of 50. onTrigger now processes a single FlowFile and relies on @SupportsBatching. ./mvnw -Pcontrib-check verify passes for nifi-standard-processors. Please take another look when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
