lordgamez commented on code in PR #2292: URL: https://github.com/apache/nifi-minifi-cpp/pull/2292#discussion_r4389188107
########## libminifi/src/c2/C2ConnectionWatchdog.cpp: ########## Review Comment: We could, the only downside is that this way the "watchdog" is tied to the C2Agent so if the C2Agent gets stuck while performing a heartbeat the shutdown is never triggered. I suppose it is not that common it could be a good tradeoff for simplifying it and avoiding the race conditions between the threads. I removed the separate watchdog thread to simplify it in https://github.com/apache/nifi-minifi-cpp/pull/2292/commits/7437475fda6b7fbec67ce184398bae103ab73b56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
