awelless commented on code in PR #11813:
URL: https://github.com/apache/nifi/pull/11813#discussion_r4403506350
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/migration/StandardControllerServiceFactory.java:
##########
@@ -104,7 +113,20 @@ public ControllerServiceNode create(final
ControllerServiceCreationDetails creat
serviceNode.setProperties(creationDetails.serviceProperties());
- final ControllerServiceFactory serviceFactory = new
StandardControllerServiceFactory(extensionManager, flowManager,
serviceProvider, serviceNode);
+ final String versionedId = generateVersionedId(creationDetails,
serviceNode);
+ if (versionedId != null) {
+ final Set<ControllerServiceNode> groupControllerServices =
group.map(processGroup ->
processGroup.getControllerServices(false)).orElse(Collections.emptySet());
+ final boolean occupied = groupControllerServices.stream()
Review Comment:
Since owning group identity is a part of the hash for versioned id, we're
checking for occupied versioned ids in the owning group only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
