awelless commented on code in PR #11857: URL: https://github.com/apache/nifi/pull/11857#discussion_r4412314323
########## nifi-extension-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/resources/docs/org.apache.nifi.kafka.processors.ConsumeKafka/additionalDetails.md: ########## @@ -23,6 +23,8 @@ This processor offers multiple output strategies (configured via processor prope - 'Use Wrapper' emits FlowFile records containing the Kafka record key, value, and headers, as well as additional metadata from the Kafka record. - 'Inject Metadata' emits FlowFile records containing the Kafka record value into which a sub record field has been added to hold metadata, headers and key information. +When Processing Strategy is RECORD, a Kafka tombstone (null value) is not written for any Output Strategy. It is skipped and offset is committed. Review Comment: Nit: I'd put tombstone handling under a separate header. Could you additionally describe the behavior for other Processing Strategies here? It isn't related to your change, but would be helpful, provided the tombstone behavior differs from strategy to strategy. > offset is committed This is true only when "Commit Offsets" is true. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
