Chaffelson commented on PR #11870: URL: https://github.com/apache/nifi/pull/11870#issuecomment-6504610753
I ran this against nipyapi, which generates its Python clients from these specs. I built the NiFi and NiFi Registry specs from this commit and from its parent (91856b4), then regenerated the clients from both with swagger-codegen 3.0.68 and diffed them. Everything looks fine from our side. - No operationId, path, parameter or request body changes in either spec, so generated method names are stable. - The NiFi spec differs only in the StreamingOutput change described above. - In the Registry spec the UriBuilder schema is also removed, since it was only referenced from Link.uriBuilder and is now inlined along with it. It might be worth adding to the list in the description. - With swagger-codegen the inlined links still come out as model classes, just with generated names: BucketLink for most of the listed properties, plus separate identical classes for ExtensionMetadata.linkDocs and the three ExtensionRepoVersion links (their descriptions differ). Field names and the JSON round trip are unchanged. So nipyapi will need a regeneration and a release note for the removed StreamingOutput, Link and UriBuilder models, but no template or code changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
