lordgamez commented on code in PR #2293: URL: https://github.com/apache/nifi-minifi-cpp/pull/2293#discussion_r4443007490
########## cmake/BundledOpenSSL.cmake: ########## Review Comment: The removed code was actually dead code, the parameter list was never passed to the build so the default visibility was used. Changing it to hidden would also break the FIPS functionality where EVP_* symbols are used, or any other extension that is using OpenSSL symbols. I would keep it the way it was before. I also fixed the C flag passing in https://github.com/apache/nifi-minifi-cpp/pull/2293/commits/7d4c096ae02d35016e3a91caa33f6445b72c59af as it the parameter name was also wrong there. ########## libminifi/CMakeLists.txt: ########## @@ -92,6 +92,13 @@ endif() if (UNIX AND (CMAKE_SYSTEM_PROCESSOR MATCHES "armv7")) target_link_libraries(core-minifi "-latomic") endif() +if (CMAKE_SYSTEM_NAME STREQUAL "Linux") + # core-minifi exports the symbols of its statically linked dependencies (e.g. OpenSSL), which extensions rely on. + # Tagging them with a minifi specific version prevents libraries loaded later (e.g. python's _hashlib referencing + # EVP_*@OPENSSL_3.0.0) from binding to these copies instead of their own dependencies (e.g. the system libcrypto). Review Comment: Moved it in https://github.com/apache/nifi-minifi-cpp/pull/2293/commits/7d4c096ae02d35016e3a91caa33f6445b72c59af -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
