mcgilman opened a new pull request, #11892: URL: https://github.com/apache/nifi/pull/11892
- support create, configure, enable, disable, change version, delete, and clear bulletins for connector Controller Services in Troubleshooting - read through connector-scoped endpoints, write through standard Controller Service endpoints, and reload when Troubleshooting ends - open the Controller Service Advanced UI from a connector, editable only when disabled and writable - model Controller Service entities in the shared library with an optional component, and guard callers for unreadable services - validate dynamic path segments in connector, Controller Service, and component history requests <!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary [NIFI-16402](https://issues.apache.org/jira/browse/NIFI-16402) Adds Controller Service management to the connector Controller Services page while the connector is in Troubleshooting. Outside Troubleshooting the page stays read-only, as it is today. In Troubleshooting, users can: - Create, configure, enable, disable, change the version of, and delete Controller Services, using the same dialogs as the flow designer. - Clear bulletins, using the most recent bulletin timestamp. - Open a service's Advanced UI. The route is guarded by Troubleshooting, and the UI is editable only when the service is disabled and writable. - Use Go To on a service defined by another process group. Back returns to the current listing. Implementation notes: - Reads go through the connector-scoped endpoints, so the listing and its view dialogs work outside Troubleshooting. Writes go through the standard Controller Service endpoints, which the server allows while the connector is in Troubleshooting. - While the page is open it polls the connector entity. When Troubleshooting ends, the listing reloads so the table returns to read-only. The reload only runs while the page's polling is active. - Delete is offered only when the user can write to the process group that defines the service. - `ControllerServiceEntity` and the referencing-component DTOs are now typed in the shared library. `component` is optional to match `ControllerServiceEntity.java`. The flow designer, settings, and shared Controller Service dialogs guard unreadable services, skip references without a group, and fall back to the id in delete prompts. - Dynamic path segments in connector, Controller Service, and component-history requests are validated with `safeApiPath` inside `defer`, so an unsafe id fails without issuing a request. No server-side changes. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - Pull Request based on current revision of the `main` branch - Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. Frontend verification from `nifi-frontend/src/main/frontend`: `npx eslint` on changed files, `npx tsc -p apps/nifi/tsconfig.app.json --noEmit`, `npx nx test nifi -- --run` (350 files, 3392 tests passing), and `npx nx build nifi`. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
