mcgilman commented on PR #11877: URL: https://github.com/apache/nifi/pull/11877#issuecomment-6689288351
Thanks for restoring the "Deprecation Notice" label. A few items before merge: 1. **Heading weight.** In the rendered docs, the heading uses `font-medium` and looks almost identical to the reason text below it, so it reads as body copy. Would you consider `font-semibold`? In this file, `font-medium` is the value style (Bundle, Description, Tags) and labels are plain, so a heavier weight would also separate the heading from the body. 2. **Connector banner.** `connector-definition.component.html` (around lines 28–41) has a hand-copied version of this banner and still shows only the reason when one is set. Please don't copy the heading into that template. `<configurable-extension-definition>` is also the wrong reuse, since it renders the full processor-oriented docs body and `ConnectorDefinition` is not a `ConfigurableExtensionDefinition`. A small shared deprecation-banner component (reason, alternatives, and a fallback noun) would fix both pages. This can be here or in a follow-up. 3. **Tests.** The two new tests repeat the full definition object and differ only by `deprecationReason`. A small factory would reduce that. Asserting on `.caution-color-background` would tie the heading to the banner instead of the whole component text. Optional: the fallback message says "this processor" for every type, and the new test pins that wording. Changing it to "this component" would be a small follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
