Vinz2168 commented on code in PR #11885:
URL: https://github.com/apache/nifi/pull/11885#discussion_r4466762403
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/dao/impl/StandardComponentStateDAO.java:
##########
@@ -108,6 +112,9 @@ private void clearState(final String componentId, final
ComponentStateDTO compon
if (hasExactlyOneKeyRemoved(currentClusterState,
newClusterState)) {
manager.setState(newClusterState, Scope.CLUSTER);
Review Comment:
I also re-ran `ClusterStateKeyDropIT` locally on a 2-node cluster with
45ebb60ef1. As before, I used temporary local delays on node 2, which are not
part of the PR. With no delay, 5/5 runs passed. With node 2 delayed before
reading the cluster state, 3/3 runs passed. With node 2 delayed between the
read and the `replace`, 3/3 runs passed: node 2's replace failed, it read the
state again and treated the request as a no-op. As a control, the same
interleaving without the read-again fallback failed 3/3 at
`testCanDropSpecificStateKey:133` with the node disconnected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
