pvillard31 commented on code in PR #11872:
URL: https://github.com/apache/nifi/pull/11872#discussion_r4496116816
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/components/connector/ConnectorRepository.java:
##########
@@ -125,10 +125,15 @@ public interface ConnectorRepository {
/**
* Starts the given Connector, managing any appropriate lifecycle events.
+ * When a flow evolution is pending, the context persists the flow after
phase one is applied, after the connector starts, and when the evolution fails.
+ * The context is required even when no evolution is pending.
+ *
* @param connector the Connector to start
+ * @param persistenceContext persists the flow during evolution
* @return a CompletableFuture that will be completed when the Connector
has started
+ * @throws NullPointerException if the persistence context is null
*/
- Future<Void> startConnector(ConnectorNode connector);
+ Future<Void> startConnector(ConnectorNode connector,
ConnectorUpdateContext persistenceContext);
Review Comment:
All things considered, I agree that evolution should be required, so a
default that skips it would be wrong. Let's just make sure we mention the
breaking change in the migration guidance in case someone has a custom
implementation of the connector repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
