lordgamez commented on code in PR #2292:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2292#discussion_r4480704352


##########
minifi_main/MiNiFiMain.cpp:
##########
@@ -79,6 +81,41 @@ namespace utils = minifi::utils;
 static std::atomic_flag flow_controller_running;
 static std::atomic_flag process_running;
 
+enum class LifecycleState : int32_t {
+  RUNNING,
+  RESTART_REQUESTED,
+  SHUTDOWN_REQUESTED
+};
+
+struct LifecycleRequest {
+  LifecycleState state = LifecycleState::RUNNING;
+  int32_t exit_code = 0;
+};
+
+static_assert(std::atomic<LifecycleRequest>::is_always_lock_free);

Review Comment:
   This assertion was added by claude code when I asked it to review for any 
remaining race conditions. The explanation was that it should be lock free 
because it is used in the signal handler, and as it can fall back to a hidden 
mutex or a lock then taking a lock inside a signal handler can deadlock if the 
signal interrupts a thread that already holds it. I think this is valid check 
and should keep it if the struct changes in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to