lordgamez commented on code in PR #2298:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2298#discussion_r4514804172
##########
CMakeLists.txt:
##########
@@ -55,6 +55,26 @@ if (DOCKER_BUILD_ONLY)
return()
endif()
+# Find bash executable
+find_package(Bash REQUIRED)
+
+# Find patch executable
+find_package(Patch REQUIRED)
+
+include(CppLint)
+add_custom_target(linter COMMAND
+ python3 ${CPPLINT_DIR}/run_linter.py -q -i
${CMAKE_SOURCE_DIR}/controller/ ${CMAKE_SOURCE_DIR}/core-framework/
${CMAKE_SOURCE_DIR}/encrypt-config/ ${CMAKE_SOURCE_DIR}/extension-framework/
${CMAKE_SOURCE_DIR}/extensions/ ${CMAKE_SOURCE_DIR}/libminifi/
${CMAKE_SOURCE_DIR}/minifi-api/ ${CMAKE_SOURCE_DIR}/minifi_main/)
+set_target_properties(linter PROPERTIES EXCLUDE_FROM_DEFAULT_BUILD TRUE)
+
+if(NOT WIN32)
+add_custom_target(shellcheck
+ COMMAND ${CMAKE_SOURCE_DIR}/run_shellcheck.sh ${CMAKE_SOURCE_DIR})
+endif(NOT WIN32)
+
Review Comment:
Bash and Patch are already hard requirements for thirdparty libraries not
just static analysis targets, so this is okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
