Adam Debreceni created MINIFICPP-2946:
-----------------------------------------

             Summary: Remove obsolete fmt version pin on windows
                 Key: MINIFICPP-2946
                 URL: https://issues.apache.org/jira/browse/MINIFICPP-2946
             Project: Apache NiFi MiNiFi C++
          Issue Type: New Feature
            Reporter: Adam Debreceni
            Assignee: Adam Debreceni


On Windows, cmake/GetSpdlog.cmake still pins fmt to 11.0.2 when building from 
source. That pin was only needed for the Windows-specific Couchbase 1.0.2 
build, which was removed in MINIFICPP-2768, while every other configuration 
(including Conan, now used by the Windows CI) moved to fmt 12.1.0. Because CI 
no longer covers this path, non-Conan Windows builds silently diverged and now 
fail to compile code that relies on newer fmt features (e.g. formatting 
std::expected<void, E> in Provenance.cpp), so the pin and the 
GetFmt_11_0_2.cmake/fmt_11_0_2.cmake files should be removed.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to