adamdebreceni commented on PR #2300: URL: https://github.com/apache/nifi-minifi-cpp/pull/2300#issuecomment-6770713657
please address the root cause: On Windows, cmake/GetSpdlog.cmake still pins fmt to 11.0.2 when building from source. That pin was only needed for the Windows-specific Couchbase 1.0.2 build, which was removed in [MINIFICPP-2768](https://issues.apache.org/jira/browse/MINIFICPP-2768), while every other configuration (including Conan, now used by the Windows CI) moved to fmt 12.1.0. Because CI no longer covers this path, non-Conan Windows builds silently diverged and now fail to compile code that relies on newer fmt features (e.g. formatting std::expected<void, E> in Provenance.cpp), so the pin and the GetFmt_11_0_2.cmake/fmt_11_0_2.cmake files should be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
