[ 
https://issues.apache.org/jira/browse/NIFI-3189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880498#comment-15880498
 ] 

ASF GitHub Bot commented on NIFI-3189:
--------------------------------------

Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1527#discussion_r102721436
  
    --- Diff: 
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-0-10-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/ConsumerPool.java
 ---
    @@ -126,6 +128,25 @@ public ConsumerLease obtainConsumer(final 
ProcessSession session) {
             return lease;
         }
     
    +    public void retainConsumers() {
    +        pooledLeases.forEach(lease -> {
    --- End diff --
    
    Is there any issue if another thread calls obtainConsumer while 
retainConsumers is in the middle of looping over the consumers?


> ConsumeKafka 0.9 and 0.10 can cause consumer rebalance when backpressure is 
> engaged
> -----------------------------------------------------------------------------------
>
>                 Key: NIFI-3189
>                 URL: https://issues.apache.org/jira/browse/NIFI-3189
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: Joseph Witt
>            Assignee: Koji Kawamura
>
> ConsumeKafka processors can alert to rebalance issues when backpressure is 
> engaged on the output connection and is then freed up.  This is because we're 
> not doing anything with those consumers for a period of time and the kafka 
> client detects this and initiates a rebalance.  We should ensure that even 
> when we cannot send more data due to back pressure that we at least have some 
> sort of keep alive behavior with the kafka client.  Or, if that isn't an 
> option we should at least document the situation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to