Vinz2168 opened a new pull request, #11912: URL: https://github.com/apache/nifi/pull/11912
<!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary [NIFI-16572](https://issues.apache.org/jira/browse/NIFI-16572) MiNiFi Java already contains the framework side of per Process Group logging (NIFI-3065): `StandardProcessGroup` keeps the `logFileSuffix` from the flow and `StandardComponentLog` attaches it as a key/value pair to every component log event. The distribution, however, does not ship the routing pieces, so a `logFileSuffix` set in `flow.json` currently has no effect. This PR: - adds `nifi-per-process-group-logging` (containing `NifiDiscriminator`) to `minifi-assembly` and includes it in `lib/` through both `dependencies.xml` and `dependencies-windows-service.xml`. The bootstrap classpath already includes `lib/*` on both `minifi.sh` and the Windows scripts, so the bootstrap can also resolve the discriminator when it reads the shared `logback.xml`; - adds a `DEDICATED_LOGGING` `SiftingAppender` to the default MiNiFi `conf/logback.xml`, referenced by `<root>`. Files are named `${app.file.name}-<suffix>.${app.file.extension}` (by default `minifi-app-<suffix>.log`) and use the same rolling limits as `APP_FILE` (10MB / 10 files / 100MB, gzip). As in NiFi, only messages emitted through the component `getLogger()` are routed; events without a suffix are ignored by the discriminator. Manual verification on a built assembly: a flow with a child Process Group with `"logFileSuffix": "foo"` (GenerateFlowFile -> LogMessage) and a control GenerateFlowFile -> LogMessage in the root group. `logs/minifi-app-foo.log` contained only the child group messages, `logs/minifi-app.log` contained both, and no logback configuration errors were reported by bootstrap or runtime. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - [x] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
