[ 
https://issues.apache.org/jira/browse/NIFI-16588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18146166#comment-18146166
 ] 

ASF subversion and git services commented on NIFI-16588:
--------------------------------------------------------

Commit a8473d374c976660e4ef3aa932936adaa1e21dbd in nifi's branch 
refs/heads/main from Raul Roberto da Silva
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=a8473d374c9 ]

NIFI-16588 Declare the GitHub client pattern variable final (#11931)

> GitHub Flow Registry Client should get the latest commit of a flow file with 
> one request
> ----------------------------------------------------------------------------------------
>
>                 Key: NIFI-16588
>                 URL: https://issues.apache.org/jira/browse/NIFI-16588
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions, Flow Versioning
>            Reporter: Raul Roberto da Silva
>            Assignee: Raul Roberto da Silva
>            Priority: Major
>             Fix For: 2.13.0
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> {{GitHubRepositoryClient}} does not override {{getLatestCommitSha(path, 
> branch)}}, so the Git flow registry falls back to listing commits. On GitHub 
> that means {{getRef}}, a page of commits and one author lookup per commit not 
> in the commit cache. With more than a thousand versioned process groups the 
> cache does not hold, and every synchronization of a process group costs about 
> 12 REST requests, which alone can exhaust the 15,000 requests/hour of a 
> GitHub App installation.
> The GitLab client already answers this question with one request. This change 
> does the same for GitHub: {{GET 
> /repos/\{owner\}/\{repo\}/commits?path=...&sha=...&per_page=1}}, through 
> {{queryCommits().path(..).from(..).pageSize(1)}}. A missing path or branch 
> keeps the existing error.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
  • [jira] [Commented] (NIFI... ASF subversion and git services (Jira) via issues
    • [jira] [Commented] ... ASF subversion and git services (Jira) via issues

Reply via email to