Rarasinhoo commented on PR #11926:
URL: https://github.com/apache/nifi/pull/11926#issuecomment-6952786507

   6163c763 tightens a few points found while reviewing the redesign again:
   
   - The ordering of head checks is gone. A call whose head check was answered 
after a later call's could reuse the state that call had moved, which may be 
for an older head. Now each call answers for the head it saw 
(`testEachCallAnswersForTheHeadItSaw` fails on the previous commit). Moving a 
state locks only its branch, so a slow comparison no longer blocks other 
branches.
   - The connector keeps the stored answer through rate limiting or server 
errors, so the next head check stays conditional, and forgets it only on Not 
Found or Gone. A new test builds a hub4j `GitHub` on the connector and reads 
the branch head from a `304` answer.
   - Compared paths are matched against the Repository Path without leading or 
trailing slashes, so `/flows/` still drops the right entries.
   - A failed comparison is logged at warning level unless the previous head 
was not found (debug), and `getLatestCommitShaAtCommit` documents its 
`UnsupportedOperationException`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to