adamdebreceni commented on code in PR #2268:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2268#discussion_r4610213578


##########
extensions/opc/src/BaseOPCProcessor.cpp:
##########
@@ -93,7 +93,7 @@ void BaseOPCProcessor::onSchedule(core::ProcessContext& 
context, core::ProcessSe
 
 bool BaseOPCProcessor::reconnect() {
   if (connection_ == nullptr) {
-    connection_ = opc::Client::createClient(logger_, application_uri_, 
cert_buffer_, key_buffer_, trust_buffers_);
+    connection_ = opc::Client::createClient(logger_, application_uri_, 
cert_buffer_, key_buffer_, trust_buffers_, max_event_queue_size_);

Review Comment:
   it seems to me FetchOPCEvents cannot trigger this connection_ == nullptr 
branch, would it be possible to move max_event_queue_size_ out of 
BaseOPCProcessor, or alternatively remove the explicit client creation in 
FetchOPCEvents and leave it to BaseOPCProcessor



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to