lordgamez commented on code in PR #2307:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2307#discussion_r4612436372
##########
bootstrap/package_manager.py:
##########
@@ -266,6 +323,7 @@ def _get_activate_venv_path():
def _minifi_setup_env_str(vs_where_location: VsWhereLocation) -> str:
return f"""
call refreshenv
+set _OLD_VIRTUAL_PATH=
Review Comment:
In the python virtualenv `_OLD_VIRTUAL_PATH` is set to restore the original
`PATH` when the venv is deactivated later. When we start a new process this
variable is inherited and after we call `refreshenv` the next step is
activating the venv in the child process which restores the `_OLD_VIRTUAL_PATH`
if that is defined, meaning it will remove the newly added paths in the `PATH`
variable like the rust paths we just installed with rustup. The fix is to clear
this variable before activating the venv in the subprocess. I'll add a comment
for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]