pvillard31 commented on code in PR #11844:
URL: https://github.com/apache/nifi/pull/11844#discussion_r4615059105


##########
nifi-commons/nifi-web-client/src/main/java/org/apache/nifi/web/client/StandardHttpUriBuilder.java:
##########


Review Comment:
   Should the Javadoc on HttpUriBuilder say that the builder encodes the name 
and value, so callers know they must not encode them first?
   
   Also cc'ing @exceptionfactory for thoughts here. It is a behavior change so 
we need extra care even it feels like we should make this change. The concern 
is for users outside of this repo but a note in the migration guidance page 
could be enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to