lordgamez commented on code in PR #2287:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2287#discussion_r4644902515


##########
PROCESSORS.md:
##########
@@ -1129,6 +1130,47 @@ In the list below, the names of required properties 
appear in bold. Any other pr
 | success | Successfully retrieved OPC-UA events |
 
 
+## FetchOPCFile
+
+### Description
+
+Fetches the content of an OPC UA FileType node using its Open, Read and Close 
methods.
+
+### Properties
+
+In the list below, the names of required properties appear in bold. Any other 
properties (not in bold) are considered optional. The table also indicates any 
default values, and whether a property supports the NiFi Expression Language.
+
+| Name                            | Default Value | Allowable Values           
      | Description                                                             
                                                                                
                                                                                
                                                                           |
+|---------------------------------|---------------|----------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| **OPC server endpoint**         |               |                            
      | Specifies the address, port and relative path of an OPC endpoint        
                                                                                
                                                                                
                                                                           |
+| Application URI                 |               |                            
      | Application URI of the client in the format 
'urn:unconfigured:application'. Mandatory, if using Secure Channel and must 
match the URI included in the certificate's Subject Alternative Names.          
                                                                                
                           |
+| Username                        |               |                            
      | Username to log in with.                                                
                                                                                
                                                                                
                                                                           |
+| Password                        |               |                            
      | Password to log in with.<br/>**Sensitive Property: true**               
                                                                                
                                                                                
                                                                           |
+| Certificate path                |               |                            
      | Path to the DER-encoded cert file                                       
                                                                                
                                                                                
                                                                           |
+| Key path                        |               |                            
      | Path to the DER-encoded key file                                        
                                                                                
                                                                                
                                                                           |

Review Comment:
   Originally we only used DER key format for the initial processors, but from 
what I see in the open62541 library PEM is also supported with and without 
password. As the PEM keys are also converted to DER format in the library, and 
from what I see in the git logs, PEM support was probably added later than the 
first introduced OPC UA processors, that is why it was not supported before. We 
can add the support for it, but as this is a common feature that affects all 
processors I would handle it separately, I created a new jira for it: 
https://issues.apache.org/jira/browse/MINIFICPP-2953



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to