exceptionfactory commented on code in PR #11898:
URL: https://github.com/apache/nifi/pull/11898#discussion_r4655563843


##########
nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/manager/ControllerServiceEntityMerger.java:
##########
@@ -122,6 +128,11 @@ private static void mergeDtos(final ControllerServiceDTO 
clientDto, final Map<No
         // merge the referencing components
         mergeControllerServiceReferences(referencingComponents, 
nodeReferencingComponentsMap);
 
+        // Nodes that disagree on a stable state have not all completed a 
transition, so report the service as transitioning
+        if (state == null && enabledOnAnyNode && disabledOnAnyNode) {
+            state = ControllerServiceState.DISABLING.name();

Review Comment:
   It seems a little odd to use `DISABLING` here when some nodes are 
`ENABLING`. Perhaps this highlights the need for a new intermediate status?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to