[
https://issues.apache.org/jira/browse/NIFI-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892281#comment-15892281
]
ASF GitHub Bot commented on NIFI-1449:
--------------------------------------
GitHub user trixpan opened a pull request:
https://github.com/apache/nifi/pull/1553
NIFI-1449 - Migrate PutEmail tests from Mock class to ListenSMTP
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [X] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [X] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trixpan/nifi NIFI-1449
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1553.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1553
----
commit 707b7aa7d8285f2e199ab5b0a03e4bbcc3340855
Author: Andre F de Miranda <[email protected]>
Date: 2017-03-02T13:23:26Z
NIFI-1449 - Migrate PutEmail tests from Mock class to ListenSMTP
----
> PutEmail needs more unit tests
> ------------------------------
>
> Key: NIFI-1449
> URL: https://issues.apache.org/jira/browse/NIFI-1449
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Joseph Percivall
> Assignee: Andre F de Miranda
>
> Currently the standard processor PutEmail only has two units. One verifies
> "testHostNotFound" and the other "testEmailPropertyFormatters". Both route to
> failure. There is no checking that the processor actually functions.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
