[
https://issues.apache.org/jira/browse/NIFI-3543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892376#comment-15892376
]
ASF GitHub Bot commented on NIFI-3543:
--------------------------------------
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1548#discussion_r103945068
--- Diff:
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-cf-service/src/main/java/org/apache/nifi/jms/cf/JMSConnectionFactoryProvider.java
---
@@ -178,7 +178,7 @@ private void
setConnectionFactoryProperties(ConfigurationContext context) {
} else {
if (propertyName.equals(BROKER)) {
if
(context.getProperty(CONNECTION_FACTORY_IMPL).evaluateAttributeExpressions().getValue().startsWith("org.apache.activemq"))
{
- this.setProperty("brokerURL", entry.getValue());
+ this.setProperty("brokerURL",
context.getProperty(descriptor).evaluateAttributeExpressions().getValue());
--- End diff --
Unfortunately this only addresses the IF and not the ELSE where the value
is treated differently to account for providers other then ActiveMQ. So, if
we're adding EL support for 'brokerURL' we should do it for all.
Also, with EL one must account for a possibility of null.
Anyway, if please address it when you get a chance or let us know if you
don't have time and one of us can essentially collaborate and address the
comments above.
> EL is not working for jms-cf-service Broker URL
> -----------------------------------------------
>
> Key: NIFI-3543
> URL: https://issues.apache.org/jira/browse/NIFI-3543
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.1.0, 1.1.1
> Reporter: Shelly Liu
> Priority: Minor
> Fix For: 1.2.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
