[
https://issues.apache.org/jira/browse/NIFI-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892786#comment-15892786
]
ASF GitHub Bot commented on NIFI-3548:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1555
NIFI-3548: Fixed bug that caused failed requests to not get removed f…
…rom 'request map' and also results in that preventing the purging logic,
which would then unintentially throw exceptions
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-3548
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1555.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1555
----
commit 1d931efa93029684a0700cba94e9a0d9b941f69e
Author: Mark Payne <[email protected]>
Date: 2017-03-02T18:55:15Z
NIFI-3548: Fixed bug that caused failed requests to not get removed from
'request map' and also results in that preventing the purging logic, which
would then unintentially throw exceptions
----
> Cluster Replication - Issue following MAX_REQUEST failures
> ----------------------------------------------------------
>
> Key: NIFI-3548
> URL: https://issues.apache.org/jira/browse/NIFI-3548
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Matt Gilman
> Priority: Critical
> Fix For: 1.2.0
>
>
> Once a set number of requests fail, the request replicator will be unable to
> replicate new requests. This happens because on failure, the response is not
> cleaned up. Once we've encountered MAX_REQUEST failures, all subsequent
> requests will attempt to purge the previous responses. This action is causing
> the previous failure to be re-thrown. We need to update the request
> replication to:
> - Clean up failed responses
> - Do not re-throw the previous failures when attempting to purge
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
