Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1553#discussion_r104022318
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java
---
@@ -230,27 +234,42 @@ public void testOutgoingMessageAttachment() throws
Exception {
runner.assertAllFlowFilesTransferred(PutEmail.REL_SUCCESS);
// Verify that the Message was populated correctly
- assertEquals("Expected a single message to be sent", 1,
processor.getMessages().size());
- Message message = processor.getMessages().get(0);
- assertEquals("[email protected]", message.getFrom()[0].toString());
- assertEquals("X-Mailer Header", "TestingNiFi",
message.getHeader("X-Mailer")[0]);
- assertEquals("[email protected]",
message.getRecipients(RecipientType.TO)[0].toString());
-
- assertTrue(message.getContent() instanceof MimeMultipart);
-
- final MimeMultipart multipart = (MimeMultipart)
message.getContent();
- final BodyPart part = multipart.getBodyPart(0);
- final InputStream is = part.getDataHandler().getInputStream();
- final String decodedText =
StringUtils.newStringUtf8(Base64.decodeBase64(IOUtils.toString(is, "UTF-8")));
- assertEquals("Message Body", decodedText);
-
- final BodyPart attachPart = multipart.getBodyPart(1);
- final InputStream attachIs =
attachPart.getDataHandler().getInputStream();
- final String text = IOUtils.toString(attachIs, "UTF-8");
- assertEquals("Some text", text);
-
- assertNull(message.getRecipients(RecipientType.BCC));
- assertNull(message.getRecipients(RecipientType.CC));
+ assertEquals("Expected a single message to be sent", 1,
smtpRunner.getFlowFilesForRelationship(PutEmail.REL_SUCCESS).size());
+
+ MockFlowFile message;
+
+ message =
smtpRunner.getFlowFilesForRelationship(PutEmail.REL_SUCCESS).get(0);
+
+ extractHeadersRunner.enqueue(message);
+ extractHeadersRunner.run();
+ extractHeadersRunner.shutdown();
+
+ message =
extractHeadersRunner.getFlowFilesForRelationship(ExtractEmailHeaders.REL_SUCCESS).get(0);
+
+ assertEquals("[email protected]",
message.getAttribute("email.headers.from.0"));
+ assertEquals("X-Mailer Header", "TestingNiFi",
message.getAttribute("email.headers.x-mailer"));
+
+ // Needed in order to avoid errors like
+ // "already in use for an active callback or InputStream created
by ProcessSession.read(FlowFile) has not been closed"
+
+
+ message =
extractHeadersRunner.getFlowFilesForRelationship(ExtractEmailHeaders.REL_SUCCESS).get(0);
+
+// extractAttachmentsRunner.enqueue(message);
+// extractAttachmentsRunner.run();
+//
+// final List<MockFlowFile> splits =
extractAttachmentsRunner.getFlowFilesForRelationship(ExtractEmailAttachments.REL_ATTACHMENTS);
+//
+// final MimeMultipart multipart = (MimeMultipart)
message.getContent();
+// final BodyPart part = multipart.getBodyPart(0);
+// final InputStream is = part.getDataHandler().getInputStream();
+// final String decodedText =
StringUtils.newStringUtf8(Base64.decodeBase64(IOUtils.toString(is, "UTF-8")));
+// assertEquals("Message Body", decodedText);
+//
+// final BodyPart attachPart = multipart.getBodyPart(1);
+// final InputStream attachIs =
attachPart.getDataHandler().getInputStream();
+// final String text = IOUtils.toString(attachIs, "UTF-8");
+// assertEquals("Some text", text);
--- End diff --
I see. Then we need to look at it as it may be a nasty bug in the processor
itself with the way FlowFile(s) interacts with session. The test helped to
uncover the issue that IMHO needs to be addressed before the merge. If you want
I can take a look at it. LMK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
