[ 
https://issues.apache.org/jira/browse/NIFI-3543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893681#comment-15893681
 ] 

ASF GitHub Bot commented on NIFI-3543:
--------------------------------------

Github user ShellyLC commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1548#discussion_r104083798
  
    --- Diff: 
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-cf-service/src/main/java/org/apache/nifi/jms/cf/JMSConnectionFactoryProvider.java
 ---
    @@ -178,7 +178,7 @@ private void 
setConnectionFactoryProperties(ConfigurationContext context) {
                 } else {
                     if (propertyName.equals(BROKER)) {
                         if 
(context.getProperty(CONNECTION_FACTORY_IMPL).evaluateAttributeExpressions().getValue().startsWith("org.apache.activemq"))
 {
    -                        this.setProperty("brokerURL", entry.getValue());
    +                        this.setProperty("brokerURL", 
context.getProperty(descriptor).evaluateAttributeExpressions().getValue());
    --- End diff --
    
    Thank you for your comments. I'll address the ELSE and account for the 
possibility of null. 


> Add support for using EL when defining 'brokerURL' in jms-cf-service
> --------------------------------------------------------------------
>
>                 Key: NIFI-3543
>                 URL: https://issues.apache.org/jira/browse/NIFI-3543
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.1.0, 1.1.1
>            Reporter: Shelly Liu
>            Priority: Minor
>             Fix For: 1.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to