Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104301026
--- Diff: libminifi/include/FlowFileRecord.h ---
@@ -108,6 +109,10 @@ class FlowFileRecord
* Create a new flow record
*/
FlowFileRecord(std::map<std::string, std::string> attributes,
ResourceClaim *claim = NULL);
+ /*!
+ * Create a new flow record from repo flow event
+ */
+ FlowFileRecord(FlowFileEventRecord *event);
--- End diff --
will use explicit, i am not using smart pointer here is that if you look at
where we construct FlowFileRecord from FlowFileEventRecord, i am using a
FlowFileEventRecord in the stack to. I want to avoid to create a new
FlowFileEventRecord every time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
