Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1537
Thanks for the update @ambud, the tests are passing. I have two other
comments:
1.) Similar attributes, like RESULT_ROW_COUNT are defined as static final
member variables, so they can be referenced consistently (mostly in tests). I
recommend we do the same for table.name.
2.) I looked for an established attribute naming convention that would
apply to `table.name`.
* The ListDatabaseTables processor uses `db.table.name`, but it has a
consistent `db.*` pattern for all of its attributes that QueryDatabaseTable
does not.
* QueryDatabaseTable has `querydbtable.row.count`, which might suggest a
`querydbtable.*` pattern like `querydbtable.table.name`, except that there is
only one such attribute (the fragment attributes are idiomatic and might not
apply, `maxvalue.*` is the only other existing attribute written).
Having done this research, I'm now more confused than when I started :), so
I don't have the concrete recommendation I was hoping to arrive at. Have you
looked into this, and how did you arrive at `table.name`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
