[
https://issues.apache.org/jira/browse/NIFI-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898689#comment-15898689
]
ASF GitHub Bot commented on NIFI-3517:
--------------------------------------
GitHub user jskora opened a pull request:
https://github.com/apache/nifi/pull/1567
NIFI-3517 If HandleHttpResponse cannot write response remove entry from
HttpContextMap
* Add test for failure not clear context map.
* Add handler to remove context map entry if ProcessException occurs during
while exporting response.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jskora/nifi NIFI-3517-1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1567.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1567
----
commit 3aabd1eb23efb84d842489adcff55463633885f3
Author: Joe Skora <[email protected]>
Date: 2017-03-07T01:25:06Z
NIFI-3517 If HandleHttpResponse cannot write response remove entry from
HttpContextMap.
* Add test for failure not clear context map.
* Add handler to remove context map entry if ProcessException occurs during
while exporting response.
----
> If HandleHttpResponse cannot write response, remove entry from HttpContextMap
> -----------------------------------------------------------------------------
>
> Key: NIFI-3517
> URL: https://issues.apache.org/jira/browse/NIFI-3517
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 0.7.1
> Reporter: Mark Payne
> Assignee: Joe Skora
>
> Currently, if HandleHttpResponse cannot write to the OutputStream, it catches
> the general Exception and routes to 'failure' without removing the entry from
> the map. If clients often timeout, though, we will fail to write to the
> OutputStreams and then leave the entry in the map, preventing new connections.
> If a ProcessException is caught when calling ProcessSession.exportTo, we
> should remove the entry from the map before routing to failure.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
