Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104687778
  
    --- Diff: libminifi/test/unit/ProvenanceTestHelper.h ---
    @@ -20,6 +20,62 @@
     
     #include "Provenance.h"
     #include "FlowController.h"
    +#include "FlowFileRepository.h"
    +
    +/**
    + * Test repository
    + */
    +class FlowTestRepository : public FlowFileRepository
    --- End diff --
    
    These are nearly Identical, why not just make one that inherits from 
Repository?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to