Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1570
@pvillard31, this PR looks pretty good to me:
* Passes full build with contrib-check
* Unit test exercises the schema parsing issue
* Processor change fixes the schema parsing issue
One thing I would mention is that the unit test captures the complete
context of the user experience from Jinli Liang, but it is more than necessary
for the underlying issue. A smaller unit test would still cover the issue and
be clearer about the focus:
@Test
public void testParseSchemaCommaBoundary() {
final TestRunner runner = TestRunners.newTestRunner(new
ValidateCsv());
runner.setProperty(ValidateCsv.SCHEMA, "Null(),Null");
runner.assertValid();
}
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
