[
https://issues.apache.org/jira/browse/NIFI-3568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901982#comment-15901982
]
ASF GitHub Bot commented on NIFI-3568:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1577
NIFI-3568: Use a cached thread pool in order to allow ThreadPoolReque…
…stReplicator to scale up the number of threads to some configurable max
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-3568
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1577.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1577
----
commit 864c9db7ee333d220791723f395d8a9eba42a82e
Author: Mark Payne <[email protected]>
Date: 2017-03-08T15:04:53Z
NIFI-3568: Use a cached thread pool in order to allow
ThreadPoolRequestReplicator to scale up the number of threads to some
configurable max
----
> Default thread pool that is created for cluster request replication is not
> sufficient
> -------------------------------------------------------------------------------------
>
> Key: NIFI-3568
> URL: https://issues.apache.org/jira/browse/NIFI-3568
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Mark Payne
>
> I have a cluster of 3 nodes. When the nodes are under heavy load, I notice
> that API requests sometimes complete in 10's to 100's of milliseconds but
> sometimes take several seconds (8+ seconds, at times).
> After doing some investigation, it appears to be due to the fact that the
> default thread pool size of 10 is not sufficient anymore. In the 0.x
> baseline, it was okay because each time that a user clicks "Refresh" on the
> UI it was a single request. With the 1.x baseline, this results in 4 separate
> requests fired off simultaneously due to the multi-tenancy features added. As
> a result, these 4 requests need to be replicated to 3 nodes each, which is 12
> web requests that have to occur. So even a simple Refresh on the UI cannot be
> fully done in parallel.
> Changing my pool size from 10 to 30 resulted in far more consistent response
> times. Unfortunately, scaling the thread pool up to a large number of threads
> can have its cons, too. So will create a "cached" thread pool and expose
> properties for the "core pool size" and the "max pool size".
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
