[
https://issues.apache.org/jira/browse/NIFI-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905119#comment-15905119
]
Brandon DeVries commented on NIFI-1352:
---------------------------------------
[~ggwizdz1], cool!. Just one thought... would it be worth trying to truncate
the comment if it is too long, rather than throwing an exception? We do
something similar in StandardRecordWriter.getCharsInUTF8Limit()\[1]. We can
probably just copy and use that with a limit of 0xFFFF.
\[1]
https://github.com/jskora/nifi/blob/master/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/StandardRecordWriter.java#L219-L242
> Add ability to add a zip comment in MergeContent
> ------------------------------------------------
>
> Key: NIFI-1352
> URL: https://issues.apache.org/jira/browse/NIFI-1352
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Brandon DeVries
> Assignee: Gray Gwizdz
> Priority: Trivial
> Attachments:
> 0001-NIFI-1352-Add-ability-to-add-a-zip-comment-in-MergeC.patch
>
>
> The Zip format includes a file comment, which can be written with a
> ZipOutputStream \[1\]. Modify MergeContent to optionally include a comment
> (possibly via a "zip.comment" attribute or something...).
> \[1\]
> https://docs.oracle.com/javase/7/docs/api/java/util/zip/ZipOutputStream.html#setComment%28java.lang.String%29
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
