Github user scottyaslan commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1585#discussion_r105746348
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml
 ---
    @@ -440,6 +440,7 @@
                                                     
<include>${staging.dir}/js/nf/canvas/nf-clipboard.js</include>
                                                     
<include>${staging.dir}/js/nf/canvas/nf-custom-ui.js</include>
                                                     
<include>${staging.dir}/js/nf/canvas/nf-canvas-utils.js</include>
    +                                                
<include>${staging.dir}/js/nf/canvas/nf-component-version.js</include>
    --- End diff --
    
    I think we can move this down in the order. If you move it below the 
nf-process-group-configuration.js. then in the nfProcessGroupConfiguration 
module you can load nfComponentVersion module. If you do this then you can 
avoid having to inject the nfProcessGroupConfiguration module into the 
nfComponentVersion module in the nf-canvas-bootstrap.js.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to